docs: bring the README up to date with plan 4 - #16
Merged
Merged
Conversation
The redesign changed facts the README still stated from before it: - 94 seeded services, not 91 — plan 4 added the three national emergency rows - hosting is live, not planned - the light-first theme and its toggle, and the quick exit, were undocumented - the Lighthouse line implied the >= 95 budget was met; /sok scores 67-74 and misses it, LCP-bound on the first result heading. Reported, not tuned away. Numbers read off SeedDataTests and PR #12's measurement table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation only — no code, no data, no workflow changes.
The redesign (#12) changed four things the README still described from before it:
/sok67-74 and missing itThe Lighthouse change is the one worth reading. The old wording implied the budget was met.
It now says plainly that
/sokmisses it, that the cause is LCP on the first result heading —which cannot paint before the API answers — and that I reported it rather than tuned it away.
Numbers are read off
api/Varde.Tests/Integration/SeedDataTests.cs(94 resources, 8municipalities, 9 categories) and the measurement table in #12, not from memory.
Also re-checked and left unchanged: the four API endpoints match the controllers, the three
workflows and their triggers match
.github/workflows/, port 5005 matcheslaunchSettings.jsonand
api.ts,npm run fontsexists, and every referenced doc path resolves.